Use send instead of sendmsg to send with no fds
#673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix the failing FreeBSD CI test, and behave correctly. This is perhaps better, though I think either *should* work (bytecodealliance/rustix#914). The other `sendmsg`/`recvmsg` calls use `rustix::cmsg_space!`, and should work without issue.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #673 +/- ##
===========================================
+ Coverage 51.23% 73.31% +22.08%
===========================================
Files 43 47 +4
Lines 7429 7847 +418
===========================================
+ Hits 3806 5753 +1947
+ Misses 3623 2094 -1529
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the failing FreeBSD CI test, and behave correctly. This is perhaps better, though I think either should work (bytecodealliance/rustix#914).
The other
sendmsg/recvmsgcalls userustix::cmsg_space!, and should work without issue.